FIX: Broken hashtags on embed and publish pages #24210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't have icons or access to the JS that transforms hashtag icon placeholders into their proper icons and colours on embed and publish pages, we need to at least show _something_ and make sure the hashtags are not totally broken on these pages.
martin-brennan
force-pushed
the
issue/hashtags-on-embed-and-publish
branch
from
38ca509
to
65b83fa
Compare
featheredtoast
approved these changes
Nov 2, 2023
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/the-links-in-the-discourse-blog-replies-looks-off/279798/10 |
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't have icons or access to the JS that transforms
hashtag icon placeholders into their proper icons and colours
on embed and publish pages, we need to at least show something
and make sure the hashtags are not totally broken on these pages.
Not ideal, but it would be a lot of effort to make this show the correct
thing.